gh-145177: Put node version into emscripten/config.toml as well.#146156
gh-145177: Put node version into emscripten/config.toml as well.#146156freakboy3742 merged 4 commits intopython:mainfrom
Conversation
This is the last bit of config that is in the buildbot config that we should move to the cpython repo.
hoodmane
added
skip news
OS-emscripten
needs backport to 3.14
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 4f39165 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146156%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
* Use the build script from its new `Platform/emscripten/__main__.py` location * Use `python3 Platform/emscripten run` to avoid hard coding build output path * Use new `EMSDK_CACHE` environment variable to allow build script to manage Emscripten installations * Allow build script to manage node installations python/cpython#146156 has to land first
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
One minor tweak as an accomodation to those poor antipodean developers (cough... me) whose network connections are slow :-)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
* Use the build script from its new `Platform/emscripten/__main__.py` location * Use `python3 Platform/emscripten run` to avoid hard coding build output path * Use new `EMSDK_CACHE` environment variable to allow build script to manage Emscripten installations * Build libmpdec * Cache libffi and libmpdec * Allow build script to manage node installations python/cpython#146156 has to land first
|
Okay should be fixed now. |
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…nGH-146156) Configure node version as part of the emscripten build script, and install that node version if it isn't available. (cherry picked from commit 91e1312b950e3a98a9e968da02500db127e06f43) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-146159 is a backport of this pull request to the 3.14 branch. |
3 participants
This is the last bit of config that is in the buildbot config that we should move to the cpython repo.